Add S2SA nems.configure template #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing is waiting on an unrelated IC issue to be resolved. |
|
@junwang-noaa would you please comment on the |
|
With the gocart emissions updated, having an issue with the forecast during (seemingly) the first GOCART loop: The PET logs also have this error message: Seems like something that should be a straightforward error, but I'm not sure what. Error in my new Working directory: |
|
@WalterKolczynski-NOAA This is due to the volcanic emission dataset. Sorry I missed this. They are there for future years but in a different directory. If you modify the before volcano_srcfilen: ExtData/volcanic/so2_volcanic_emissions_Carns.%y4%m2%d2.rcafter volcano_srcfilen: ExtData/nexus/VOLCANO/v2021-09/%y4/so2_volcanic_emissions_Carns.%y4%m2%d2.rc I'll take blame for this one |
|
@bbakernoaa Even after making that change, I get the same error Working directory: |
|
@WalterKolczynski-NOAA I can't open up the latest log file
|
Not sure why that one was any different, but should be fixed now. |
|
@WalterKolczynski-NOAA found the error in my suggestion it should include the month in the path... my fault.... sorry
|
|
@bbakernoaa That worked, thanks. |
WalterKolczynski-NOAA
force-pushed
the
bugfix/S2SA_template
branch
from
0f0b04c
to
530f5c9
Compare
Most of the configuration was setup to allow S2SA, but there was no appropriate nems.configure template. A new one was created by starting with the S2SWA template and removing the wave portions. Also added two UFSDA scripts that were missing from the git ignore list. Fixes NOAA-EMC#1592
The experiment setup documentation for cycled mode had not been updated as coupled capability was added. Also added notes to both the cycled and forecast-only section that ATMW is currently not working.
setup_expt would only detect two of the possible S2S options when staging cycled ICs. Refs: NOAA-EMC#1592
The volcanic aerosol data was moved to a new location within the GOCART emissions directory. Refs: NOAA-EMC#1592
The enkf versions of coupled settings (DO_OCN, etc.) do not work properly because some settings have already been determined by that point based on the non-enkf versions of the settings. The enkf versions are now disabled until there is a solution (see NOAA-EMC#1692). Refs: NOAA-EMC#1593 Refs: NOAA-EMC#1692
The task list for the free-forecast was checking against a list of apps that did not include S2SA to determine whether ocnpost is included. That check is now changed to check on do_ocean rather than looking at the app directly. Refs: NOAA-EMC#1593
WalterKolczynski-NOAA
force-pushed
the
bugfix/S2SA_template
branch
from
530f5c9
to
086333a
Compare
|
While waiting for IC staging to be updated for cycled, tested using forecast-only mode instead. |
aerorahul
approved these changes
Jun 28, 2023
A couple of scripts that had been added to the git ignore list during the course of this update have since been removed and no longer need to be ignored.
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
WalterKolczynski-NOAA
added
the
CI-Orion-Ready
emcbot
added
CI-Orion-Building
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Orion-Running
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hera-Passed
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
1 similar comment
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Orion-Passed
|
Automated global-workflow Testing Results: |
| ATM_omp_num_threads: @[atm_omp_num_threads] | ||
| ATM_attributes:: | ||
| Verbosity = 0 | ||
| DumpFields = @[DumpFields] |
There was a problem hiding this comment.
Do we need this variable in GW? This might only be used for debug purpose. I think it can be set to false.
There was a problem hiding this comment.
@junwang-noaa I think we are just being consistent w/ the other nems.configure templates. It is default set to .false. I think. If not, we can address in a later PR.
| OCN_omp_num_threads: @[ocn_omp_num_threads] | ||
| OCN_attributes:: | ||
| Verbosity = 0 | ||
| DumpFields = @[DumpFields] |
| ICE_omp_num_threads: @[ice_omp_num_threads] | ||
| ICE_attributes:: | ||
| Verbosity = 0 | ||
| DumpFields = @[DumpFields] |
junwang-noaa
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the configuration was setup to allow S2SA, but there was no appropriate nems.configure template. A new one was created by starting with the S2SWA template and removing the wave portions. This functionality will support coupled DA development.
The experiment setup documentation for cycled mode had not been updated as coupled capability was added, so that has now been updated. Also added notes to both the cycled and forecast-only section that ATMW is currently not working.
Also added two UFSDA scripts that were missing from the git ignore list.
Fixes #1592
Type of change
How Has This Been Tested?
- [ ] S2SA cycled test on OrionChecklist